util: use hasOwnProperty() primordial #41692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
This comment has been minimized.
This comment has been minimized.
benjamingr
approved these changes
Jan 25, 2022
Trott
force-pushed
the
hasown-inspector
branch
from
f0f474f
to
c3920db
Compare
Trott
changed the title
Added. Thanks. |
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jan 25, 2022
Trott
force-pushed
the
hasown-inspector
branch
from
c3920db
to
55efbda
Compare
Trott
changed the title
26 tasks
|
May also want to edit the commit message ( |
Done, but the other way around. There is no ObjectHasOwn primordial which I guess makes sense because it would be the same as the ObjectPrototypeHasOwnProperty primordial--same arguments and everything. But I'm not sure why ObjectHasOwn doesn't exist. So I just switched it to ObjectPrototypeHasOwnProperty. ¯\(ツ)/¯ |
|
@Trott then this is probably fine to backport? |
Oh, yes, good point! I'll remove those labels. |
30 tasks
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
This comment has been minimized.
This comment has been minimized.
Trott
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/41692 ✔ Done loading data for nodejs/node/pull/41692 ----------------------------------- PR info ------------------------------------ Title util: use hasOwnProperty() primordial (#41692) Author Rich Trott (@Trott) Branch Trott:hasown-inspector -> nodejs:master Labels util, needs-ci Commits 1 - util: use hasOwnProperty() primordial Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41692 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tierney Cyren Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41692 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Tierney Cyren Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - util: use hasOwnProperty() primordial ℹ This PR was created on Tue, 25 Jan 2022 15:16:03 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41692#pullrequestreview-862441837 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/41692#pullrequestreview-862639477 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41692#pullrequestreview-862732432 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-27T05:45:45Z: https://ci.nodejs.org/job/node-test-pull-request/42158/ - Querying data for job/node-test-pull-request/42158/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1758126043 |
nodejs-github-bot
added
the
commit-queue-failed
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: nodejs#41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
force-pushed
the
hasown-inspector
branch
from
55efbda
to
acc92a7
Compare
|
Landed in acc92a7 |
This was referenced Jan 28, 2022
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: nodejs#41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: #41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: #41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: #41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Avoid Object.prototype.hasOwnProperty. Use primordial instead. PR-URL: #41692 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use primordial ObjectPrototypeHasOwnProperty primordial.