doc: clarify treatment of non-string argument to new URL() #41658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
richardlau
approved these changes
Jan 23, 2022
Trott
added
the
author ready
VoltrexKeyva
approved these changes
Jan 23, 2022
TimothyGu
reviewed
Jan 23, 2022
Co-authored-by: Timothy Gu <timothygu99@gmail.com>
Trott
commented
Jan 23, 2022
| @@ -131,7 +131,7 @@ return `true`. | |||
|
|
|||
| * `input` {string} The absolute or relative input URL to parse. If `input` | |||
| is relative, then `base` is required. If `input` is absolute, the `base` | |||
| is ignored. | |||
| is ignored. If `input` is not a string, it is [converted to a string][] first. | |||
| * `base` {string|URL} The base URL to resolve against if the `input` is not | |||
There was a problem hiding this comment.
base is also USVString so perhaps this should be {string} rather than {string|URL} and also include the note about being converted to a string that is added on line 134 for input.
There was a problem hiding this comment.
baseis alsoUSVStringso perhaps this should be{string}rather than{string|URL}and also include the note about being converted to a string that is added on line 134 forinput.
@TimothyGu @jasnell Sound OK to you?
lpinca
approved these changes
Jan 23, 2022
RaisinTen
approved these changes
Jan 23, 2022
Mesteery
approved these changes
Jan 23, 2022
benjamingr
approved these changes
Jan 24, 2022
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41658 ✔ Done loading data for nodejs/node/pull/41658 ----------------------------------- PR info ------------------------------------ Title doc: clarify treatment of non-string argument to new URL() (#41658) Author Rich Trott (@Trott) Branch Trott:newurl -> nodejs:master Labels doc, url, author ready Commits 2 - doc: clarify treatment of non-string argument to new URL() - Update doc/api/url.md Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41658 Fixes: https://github.com/nodejs/node/issues/41653 Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Mestery Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41658 Fixes: https://github.com/nodejs/node/issues/41653 Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Mestery Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Jan 2022 00:21:07 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41658#pullrequestreview-860252993 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41658#pullrequestreview-860254672 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41658#pullrequestreview-860283743 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41658#pullrequestreview-860316074 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41658#pullrequestreview-860318289 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41658#pullrequestreview-861643651 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41658 From https://github.com/nodejs/node * branch refs/pull/41658/merge -> FETCH_HEAD ✔ Fetched commits as b27ae24dcc42..ff5b5a438465 -------------------------------------------------------------------------------- [master fb622bf670] doc: clarify treatment of non-string argument to new URL() Author: Rich Trott Date: Sat Jan 22 16:18:30 2022 -0800 1 file changed, 3 insertions(+), 2 deletions(-) [master 93ce1361e9] Update doc/api/url.md Author: Rich Trott Date: Sat Jan 22 22:30:00 2022 -0800 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/1743119502 |
benjamingr
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 88a3bd5 |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Closes: nodejs#41653 PR-URL: nodejs#41658 Fixes: nodejs#41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Closes: #41653 PR-URL: #41658 Fixes: #41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Closes: #41653 PR-URL: #41658 Fixes: #41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Closes: #41653 PR-URL: #41658 Fixes: #41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Closes: #41653 PR-URL: #41658 Fixes: #41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #41653