lib: modify DOMException to pass WPT
#41517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Jan 14, 2022
| @@ -86,11 +99,17 @@ class DOMException extends Error { | |||
| if (internals === undefined) { | |||
| throwInvalidThisError(TypeError, 'DOMException'); | |||
| } | |||
|
|
|||
| if (disusedNamesSet.has(internals.name)) { | |||
There was a problem hiding this comment.
Suggested change
| if (disusedNamesSet.has(internals.name)) { | |
| if (internals.name === 'DOMStringSizeError' || | |
| internals.name === 'NoDataAllowedError' || | |
| internals.name === 'ValidationError') { |
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
IIUC, this file has been auto-generated by git node wpt, so we should send a corresponding fix for this to https://github.com/nodejs/node-core-utils
benjamingr
approved these changes
Jan 15, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
jasnell
approved these changes
Jan 17, 2022
Ayase-252
added
author ready
github-actions
bot
removed
the
request-ci
13 tasks
17 tasks
XadillaX
added a commit
that referenced
this pull request
Jan 20, 2022
PR-URL: #41517 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 9759695 |
This was referenced Jan 21, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41517 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41517 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@XadillaX when pulling into the 16.x release, this throws an error in the test suite. This is the error I got: Do you mind backporting this and/or investigating? Thank you. |
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #41517 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#41517 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.