Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: consolidate update-authors.js logic #41255

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 21, 2021

Use a single regex and fewer logical branches in the code.

Use a single regex and fewer logical branches in the code.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 21, 2021
@Trott
Copy link
Member Author

Trott commented Dec 21, 2021

I tested this by making AUTHORS a zero-length file and running the script to confirm that it produced identical content to the current script.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2021
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot merged commit f72c197 into nodejs:master Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in f72c197

@Trott Trott deleted the refactor-update-authors branch December 23, 2021 06:47
targos pushed a commit that referenced this pull request Jan 14, 2022
Use a single regex and fewer logical branches in the code.

PR-URL: #41255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Use a single regex and fewer logical branches in the code.

PR-URL: #41255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Use a single regex and fewer logical branches in the code.

PR-URL: nodejs#41255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Use a single regex and fewer logical branches in the code.

PR-URL: #41255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants