Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix added: info for Readable.fromWeb() #40820

Closed
wants to merge 1 commit into from
Closed

doc: fix added: info for Readable.fromWeb() #40820

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 15, 2021

stream.Readable.fromWeb() was added to Node.js v17.0.0 via a99c230.

Refs: #40818

@lpinca
doc: fix added: info for Readable.fromWeb()
5ec14a9 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

Refs: nodejs#40818
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 15, 2021
lpinca added a commit that referenced this pull request Nov 18, 2021
@lpinca
doc: fix added: info for Readable.fromWeb()
aa394ab 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

PR-URL: #40820
Refs: #40818
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@lpinca
Copy link
Member Author

lpinca commented Nov 18, 2021

Landed in aa394ab.

@lpinca lpinca closed this Nov 18, 2021
@lpinca lpinca deleted the fix/added-version-for-fromweb branch November 18, 2021 06:21
targos pushed a commit that referenced this pull request Nov 21, 2021
@lpinca @targos
doc: fix added: info for Readable.fromWeb()
fe2cd09 
`stream.Readable.fromWeb()` was added to Node.js v17.0.0 via a99c230.

PR-URL: #40820
Refs: #40818
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
@richardlau richardlau mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @jasnell @targos @richardlau @VoltrexKeyva @nodejs-github-bot