test: eliminate multicast test FreeBSD flakiness #4042

Trott · 2015-11-26T21:44:51Z

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry
Pi. This refactoring fixes the issue by eliminating a race condition.

Fixes: #2474

Trott · 2015-11-26T21:48:40Z

This change moves process.send({ listening: true }); after the binding of events for listenSocket. Because we're dealing with separate processes, the previous arrangement resulted in a race condition.

Trott · 2015-11-26T21:50:57Z

With this change, 9999 consecutive successful runs on FreeBSD:

https://ci.nodejs.org/job/node-stress-single-test/53/nodes=freebsd102-64/console

Without this change, not so much:

https://ci.nodejs.org/job/node-stress-single-test/46/nodes=freebsd102-64/console

Trott · 2015-11-26T21:51:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/858/

Trott · 2015-11-26T21:54:34Z

/cc @defunctzombie (to confirm that the test still does what it was written to do)

cjihrig · 2015-11-26T22:05:38Z

test/internet/test-dgram-multicast-multi-process.js

-      new Buffer('Fourth message to send')
-    ];
+const common = require('../common'),
+      assert = require('assert'),


Since you're changing all of these lines, it would be awesome to split them into individual const declaration statements.

Sure, done.

jbergstroem · 2015-11-28T07:15:58Z

I think we want to skip if we're in a freebsd jail here.

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474

Trott · 2015-11-28T19:09:03Z

Added code to skip test if in a FreeBSD jail per suggestion from @jbergstroem

New CI: https://ci.nodejs.org/job/node-test-pull-request/872/

Trott · 2015-11-29T22:50:43Z

Bump. Anyone feel good enough about this for an LGTM?

defunctzombie · 2015-11-29T23:11:06Z

I won't be able to take a look until next week but am sure others can
confirm that correct behavior is sill tested.

On Monday, November 30, 2015, Rich Trott notifications@github.com wrote:

Bump. Anyone feel good enough about this for an LGTM?

—
Reply to this email directly or view it on GitHub
#4042 (comment).

bnoordhuis · 2015-11-30T16:39:44Z

test/internet/test-dgram-multicast-multi-process.js

+const common = require('../common');
+const assert = require('assert');
+const dgram = require('dgram');
+const Buffer = require('buffer').Buffer;


You can safely drop this, I think.

Trott · 2015-11-30T22:16:02Z

All nits un-nitted.

Stress test: https://ci.nodejs.org/job/node-stress-single-test/93/nodes=freebsd102-64/

CI: ~~https://ci.nodejs.org/job/node-accept-pull-request/132/~~ https://ci.nodejs.org/job/node-test-pull-request/884/

(Clearly, I should get rid of the CI node-accept-pull-request bookmark...)

bnoordhuis · 2015-11-30T23:40:02Z

test/internet/test-dgram-multicast-multi-process.js

+    if (dead === listeners) {
+      console.error('[PARENT] All workers have died.');
+      console.error('[PARENT] Fail');
+      process.exit(1);


Not a nit, more a stream-of-consciousness remark, but I would have thrown an exception here.

Not really a response but getting all stream-of-consciousness over here too: FWIW, I agree and probably would have chosen to throw an exception too and would have also not included console.error() messages here and elsewhere in the test. But those are just my personal preferences and I only wanted to go so far in rewriting existing code. All this stuff was in the existing test. It only shows up as a change because the indentation changed and/or I moved it to a different location.

bnoordhuis · 2015-11-30T23:41:57Z

LGTM

Trott · 2015-12-01T04:46:33Z

Landed in b3313aa

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474 PR-URL: nodejs#4042 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: #2474 PR-URL: #4042 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474 PR-URL: nodejs#4042 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott mentioned this pull request Nov 26, 2015

Investigate flaky test test-dgram-multicast-multi-process #2474

Closed

cjihrig reviewed Nov 26, 2015
View reviewed changes

mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Nov 26, 2015

Trott added 3 commits November 28, 2015 11:05

test: eliminate multicast test FreeBSD flakiness

c623001

test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: nodejs#2474

fixup

0f2782b

fixup: skip if in a FreeBSD jail

8021d83

Trott force-pushed the dgram-flaky branch from faed37c to 8021d83 Compare November 28, 2015 19:07

bnoordhuis reviewed Nov 30, 2015
View reviewed changes

Trott added 4 commits November 30, 2015 13:27

fixup: drop Buffer import, it is there by default in current Node

0b5c3cb

fixup: fix funky indentation

26b56c0

fixup: process.argv[1] -> filename

9b527da

fixup: hoist workers

fef9193

Trott added 5 commits November 30, 2015 13:54

fixup: copyedit comments

71470b5

fixup: remove unnecessary killChildren()

615356a

fixup: rm else

ccafb10

fixup: equal->strictEqual

bd8a3c1

fixup: typo fix

ec975e4

bnoordhuis reviewed Nov 30, 2015
View reviewed changes

Trott closed this Dec 1, 2015

This was referenced Dec 8, 2015

Release proposal: v5.2.0 #4180

Closed

Release proposal: v5.2.0 (Stable) #4181

Merged

rvagg mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

jasnell added the lts-watch-v4.x label Dec 17, 2015

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Dec 29, 2015

MylesBorins mentioned this pull request Jan 19, 2016

V4.2.5 proposal #4768

Merged

Trott deleted the dgram-flaky branch January 13, 2022 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: eliminate multicast test FreeBSD flakiness #4042

test: eliminate multicast test FreeBSD flakiness #4042

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

cjihrig Nov 26, 2015

Trott Nov 27, 2015

jbergstroem commented Nov 28, 2015

Trott commented Nov 28, 2015

Trott commented Nov 29, 2015

defunctzombie commented Nov 29, 2015

bnoordhuis Nov 30, 2015

Trott Nov 30, 2015

Trott commented Nov 30, 2015

bnoordhuis Nov 30, 2015

Trott Dec 1, 2015

bnoordhuis commented Nov 30, 2015

Trott commented Dec 1, 2015

test: eliminate multicast test FreeBSD flakiness #4042

test: eliminate multicast test FreeBSD flakiness #4042

Conversation

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

Trott commented Nov 26, 2015

cjihrig Nov 26, 2015

Choose a reason for hiding this comment

Trott Nov 27, 2015

Choose a reason for hiding this comment

jbergstroem commented Nov 28, 2015

Trott commented Nov 28, 2015

Trott commented Nov 29, 2015

defunctzombie commented Nov 29, 2015

bnoordhuis Nov 30, 2015

Choose a reason for hiding this comment

Trott Nov 30, 2015

Choose a reason for hiding this comment

Trott commented Nov 30, 2015

bnoordhuis Nov 30, 2015

Choose a reason for hiding this comment

Trott Dec 1, 2015

Choose a reason for hiding this comment

bnoordhuis commented Nov 30, 2015

Trott commented Dec 1, 2015