Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x Backport] fs: writeFile support AsyncIterable, Iterable & Stream as data argument #39973

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 1, 2021

Backport of #37508, #37490, and #39836.

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 1, 2021
@github-actions github-actions bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. v14.x labels Sep 1, 2021
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Sep 1, 2021
Trott and others added 3 commits September 2, 2021 00:19
Create a utils module for isIterable(), isReadable(), and isStream().

PR-URL: nodejs#37508
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fixes: nodejs#37391

PR-URL: nodejs#37490
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs#37490

PR-URL: nodejs#39836
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@aduh95 aduh95 force-pushed the backport-fsp-writefile-asynciterator-v14 branch from fcbf21e to 17b6ad6 Compare September 1, 2021 22:20
targos pushed a commit that referenced this pull request Sep 4, 2021
Create a utils module for isIterable(), isReadable(), and isStream().

PR-URL: #37508
Backport-PR-URL: #39973
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Fixes: #37391

PR-URL: #37490
Backport-PR-URL: #39973
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Refs: #37490

PR-URL: #39836
Backport-PR-URL: #39973
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@targos
Copy link
Member

targos commented Sep 4, 2021

Landed in 2b0e270...fe28128

@targos targos closed this Sep 4, 2021
@aduh95 aduh95 deleted the backport-fsp-writefile-asynciterator-v14 branch September 4, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants