Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: combine require() and destructure #39806

Closed
wants to merge 1 commit into from
Closed

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 19, 2021

This commit combines two require() calls and subsequent destructuring operations.

Side note: it looks like the new cp() methods use the readdir() functions. I imagine that people will use cp() to copy large directory trees. We should probably look into incorporating the streaming read dir functions.

This commit combines two require() calls and subsequent
destructuring operations.
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Aug 19, 2021
@BethGriggs BethGriggs added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2021

@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Aug 21, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2021
@github-actions
Copy link
Contributor

Landed in af45be7...1deafcd

@github-actions github-actions bot closed this Aug 21, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 21, 2021
This commit combines two require() calls and subsequent
destructuring operations.

PR-URL: #39806
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig deleted the requires branch August 21, 2021 15:37
targos pushed a commit that referenced this pull request Aug 22, 2021
This commit combines two require() calls and subsequent
destructuring operations.

PR-URL: #39806
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants