Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add known issues test for debugger heap snapshot race #39557

Closed
wants to merge 1 commit into from
Closed

test: add known issues test for debugger heap snapshot race #39557

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 28, 2021

Refs: #39555

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. debugger Issues and PRs related to the debugger subsystem. labels Jul 28, 2021
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39320/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39325/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

Landed in 4d60ee8...7db86e7

@github-actions github-actions bot closed this Aug 1, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 1, 2021
@Trott @nodejs-github-bot
test: add known issues test for debugger heap snapshot race
7db86e7 
Refs: #39555

PR-URL: #39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@Trott @danielleadams
test: add known issues test for debugger heap snapshot race
cff2aea 
Refs: #39555

PR-URL: #39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
@Trott Trott deleted the snapshot-race branch September 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @jasnell @targos