Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf_hooks: fix performance timeline wpt failures #39532

Closed
wants to merge 1 commit into from
Closed

perf_hooks: fix performance timeline wpt failures #39532

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

The WPT test runner is unexpectedly running with user-timing tests instead of performance-timeline.

@legendecas legendecas added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Jul 26, 2021
@legendecas legendecas marked this pull request as draft July 26, 2021 15:46
@legendecas legendecas marked this pull request as ready for review July 26, 2021 15:55
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2021 •
edited by legendecas
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39298/

  • not ok 3099 report/test-report-fatal-error

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 28, 2021 •
edited by legendecas
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39304/

  • not ok 1480 parallel/test-https-set-timeout-server

@legendecas legendecas mentioned this pull request Jul 29, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39350/ 💚

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2021
jasnell pushed a commit that referenced this pull request Jul 30, 2021
@legendecas @jasnell
perf_hooks: fix performance timeline wpt failures
a27d245 
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@jasnell
Copy link
Member

jasnell commented Jul 30, 2021

Landed in a27d245

@jasnell jasnell closed this Jul 30, 2021
@legendecas legendecas deleted the perf_hooks/wpt branch July 30, 2021 14:55
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@legendecas @danielleadams
perf_hooks: fix performance timeline wpt failures
b37575b 
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
@luketaher luketaher mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@XadillaX XadillaX XadillaX approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@legendecas @nodejs-github-bot @jasnell @XadillaX @targos