Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: merge resource_symbol with owner_symbol #38468

Closed
wants to merge 1 commit into from
Closed

async_hooks: merge resource_symbol with owner_symbol #38468

wants to merge 1 commit into from

Conversation

RaisinTen
Copy link
Contributor

As per this TODO comment:

node/lib/internal/async_hooks.js

Lines 182 to 183 in 6ca785b

// TODO(addaleax): Merge this with owner_symbol and use it across all
// AsyncWrap instances.

@github-actions github-actions bot added async_hooks Issues and PRs related to the async hooks subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 29, 2021
@RaisinTen
Copy link
Contributor Author

cc @addaleax

jasnell
jasnell approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but definitely want @addaleax's look as well

addaleax
addaleax approved these changes Apr 30, 2021
View reviewed changes
lib/internal/async_hooks.js Show resolved Hide resolved
lib/internal/async_hooks.js Show resolved Hide resolved
@RaisinTen RaisinTen added the wip Issues and PRs that are still a work in progress. label May 6, 2021
@RaisinTen
async_hooks: merge resource_symbol with owner_symbol
8fa2b28 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the async_hooks/merge-resource_symbol-with-owner_symbol branch from aa99773 to 8fa2b28 Compare July 26, 2021 06:31
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
Copy link
Contributor Author

CI is mostly green. Could this please have another review? cc @jasnell @addaleax @Trott @Qard

@RaisinTen RaisinTen removed the wip Issues and PRs that are still a work in progress. label Jul 26, 2021
addaleax
addaleax approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I know that the constructor name checks may seem a bit icky here, but I think in the big picture doing this is definitely worth it 👍

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 26, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/39278/ 💚

@RaisinTen
Copy link
Contributor Author

cc @nodejs/async_hooks if anyone else would also like to take a look.

@jasnell
Copy link
Member

jasnell commented Jul 28, 2021

Landed in 7ca2f13

@jasnell jasnell closed this Jul 28, 2021
jasnell pushed a commit that referenced this pull request Jul 28, 2021
@RaisinTen @jasnell
async_hooks: merge resource_symbol with owner_symbol
7ca2f13 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #38468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@RaisinTen RaisinTen deleted the async_hooks/merge-resource_symbol-with-owner_symbol branch July 31, 2021 04:54
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@RaisinTen @danielleadams
async_hooks: merge resource_symbol with owner_symbol
a80c989 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #38468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
@orgads orgads mentioned this pull request Nov 2, 2021
Closed
@orgads
Copy link
Contributor

orgads commented Nov 2, 2021

This breaks AsyncLocalStorage for TCP/TLS sockets. See #40693.

@Qard Qard mentioned this pull request Nov 6, 2021
Closed
This was referenced Jun 15, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Qard Qard Awaiting requested review from Qard

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@RaisinTen @nodejs-github-bot @jasnell @orgads @Qard @Trott @addaleax @benjamingr @targos