Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: refactor NativeModule to avoid unsafe array iteration #37656

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 8, 2021
@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. module Issues and PRs related to the module subsystem. and removed needs-ci PRs that need a full CI run. labels Mar 8, 2021
@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95 aduh95 force-pushed the module-loaders-array-iteration branch from c794620 to 0ccfd7d Compare March 13, 2021 08:57
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 13, 2021

Landed in 0ccfd7d

@aduh95 aduh95 merged commit 0ccfd7d into nodejs:master Mar 13, 2021
@aduh95 aduh95 deleted the module-loaders-array-iteration branch March 13, 2021 08:58
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #37656
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants