Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add error formatting support #37598

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Mar 4, 2021

This enables the use of format strings in our native error functions. It also includes some light usage in ModuleWrap.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 4, 2021
src/node_errors.h Outdated Show resolved Hide resolved
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Mar 6, 2021

Does this need a documentation update (for the error code) ?

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@devsnek devsnek requested a review from targos March 9, 2021 00:09
@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

Is "rebuild" or "retry" the correct button for just doing the failed runners

@targos
Copy link
Member

targos commented Mar 9, 2021

The correct button is "Resume build"

@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

Close enough 😄

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#37598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@devsnek devsnek merged commit 853086f into nodejs:master Mar 9, 2021
@devsnek
Copy link
Member Author

devsnek commented Mar 9, 2021

landed in 853086f

@devsnek devsnek deleted the better-native-errors branch March 9, 2021 16:15
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants