build,tools: remove .inc files from torque outputs #37502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the `.inc` files written by torque are empty, i.e. they are zero length. Actions in gyp generated makefiles are always run, and torque always writes out zero length files which means their timestamps are newer than any previously compiled object file. Remove the `.inc` files from the `outputs` for the `run_torque_action` so that the targets that depend on it do not get run when the zero length .inc files are updated.
|
I don't understand what's special about zero-length files. Is it a bug in |
node/deps/v8/src/torque/utils.cc Lines 316 to 332 in 76a073b old_contents.length() == 0. Is that a bug? 🤷
At the very least, prior to 79da253 we were not including all |
|
I adapted this upstream change: v8/v8@03f6029 |
|
Coverage CI run: https://ci.nodejs.org/job/node-test-commit-linux-coverage-daily/803/nodes=benchmark/console |
|
Just trying to understand the consequence of this change: does it mean that if some V8 update ends up in one of the |
@targos probably Ninja uses the contents of the source files to determine whether a recompilation is necessary rather than timestamps which make uses? Timestamps are definitely changing, build once:build again:The 0 length files get their timestamps updated after the second build.
Yes, quite possibly. I don't know how likely that is to happen without |
targos
approved these changes
Feb 24, 2021
|
I'll check if |
|
Tests are still taking more than one hour to complete even with this change, I think we still need to switch to ninja for GH Actions for the time being. |
|
Closing in favour of #37505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the
.incfiles written by torque are empty, i.e. they arezero length. Actions in gyp generated makefiles are always run, and
torque always writes out zero length files which means their timestamps
are newer than any previously compiled object file. Remove the
.incfiles from the
outputsfor therun_torque_actionso that the targetsthat depend on it do not get run when the zero length .inc files are
updated.
Fixes: #37368
Refs: #36139 (comment)