doc: change 'be will' to 'will be' #34999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
richardlau
approved these changes
Aug 31, 2020
cjihrig
approved these changes
Aug 31, 2020
| @@ -1102,7 +1102,7 @@ In either case, the handler function will be invoked with the `event` argument | |||
| passed to the `eventTarget.dispatchEvent()` function. | |||
|
|
|||
| Async functions may be used as event listeners. If an async handler function | |||
| rejects, the rejection will be captured and be will handled as described in | |||
| rejects, the rejection will be captured and will be handled as described in | |||
There was a problem hiding this comment.
Alternative (optional) suggestion to avoid double "will be"s:
Suggested change
| rejects, the rejection will be captured and will be handled as described in | |
| rejects, the rejection will be captured and handled as described in |
gireeshpunathil
approved these changes
Sep 1, 2020
HarshithaKP
approved these changes
Sep 1, 2020
addaleax
approved these changes
Sep 2, 2020
addaleax
added
the
author ready
Trott
approved these changes
Sep 2, 2020
addaleax
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/34999 ✔ Done loading data for nodejs/node/pull/34999 ----------------------------------- PR info ------------------------------------ Title doc: change 'be will' to 'will be' (#34999) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zombieleet:patch-2 -> nodejs:master Labels author ready, doc, events Commits 1 - change 'be will' to 'will be' Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/34999 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Harshitha K P Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34999 Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Gireesh Punathil Reviewed-By: Harshitha K P Reviewed-By: Anna Henningsen Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Mon, 31 Aug 2020 19:54:01 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/34999#pullrequestreview-478915711 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-478932488 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-479397513 ✔ - Harshitha K P (@HarshithaKP): https://github.com/nodejs/node/pull/34999#pullrequestreview-479401980 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/34999#pullrequestreview-480710901 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/34999#pullrequestreview-480858462 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34999 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34999/patch -------------------------------------------------------------------------------- Applying: change 'be will' to 'will be' ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- change 'be will' to 'will be' |
github-actions
bot
added
the
commit-queue-failed
addaleax
pushed a commit
that referenced
this pull request
Sep 5, 2020
PR-URL: #34999 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 3b54d0d |
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34999 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34999 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#34999 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist