Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: replace usage of internal stream state with public api #34884

Closed
wants to merge 1 commit into from
Closed

zlib: replace usage of internal stream state with public api #34884

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

Refs: #445

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/streams

@lundibundi lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Aug 23, 2020
lundibundi
lundibundi commented Aug 23, 2020
View reviewed changes
lib/zlib.js
if (typeof kind === 'function' || (kind === undefined && !callback)) {
callback = kind;
kind = this._defaultFullFlushFlag;
}

if (ws.ended) {
if (this.writableFinished) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this is slightly off since the .finished will only be set on nextTick but I guess that's okay?
/cc @ronag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

propabbly fine

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32894/

mcollina
mcollina approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. I would ask for a citgm run.

@lundibundi
Copy link
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2449/

@ronag
Copy link
Member

ronag commented Aug 23, 2020

The docs are rather unclear when exactly callback should be invoked and what that means...

@ronag

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32906/

@github-actions github-actions bot mentioned this pull request Aug 24, 2020
Open
10 tasks
This was referenced Aug 25, 2020
Open
Open
@lundibundi
Copy link
Member Author

Can someone interpret the CITGM run for me, please? Are the failures expected from other changes and this is safe to land or is it the fault of this PR since by the looks of it every more or less recent CITGM run failed.

@github-actions github-actions bot mentioned this pull request Aug 27, 2020
Open
10 tasks
@mcollina
Copy link
Member

good to go for me

@lundibundi lundibundi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 29, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2020
@github-actions
Copy link
Contributor

Landed in 7fca0df

@github-actions github-actions bot closed this Aug 29, 2020
nodejs-github-bot pushed a commit that referenced this pull request Aug 29, 2020
@lundibundi @nodejs-github-bot
zlib: replace usage of internal stream state with public api
7fca0df 
Refs: #445

PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@lundibundi lundibundi deleted the remove-internal-stream-from-zlib branch August 29, 2020 09:44
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@lundibundi @richardlau
zlib: replace usage of internal stream state with public api
94528f5 
Refs: #445

PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi @addaleax
zlib: replace usage of internal stream state with public api
41361bb 
Refs: #445

PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@lundibundi @addaleax
zlib: replace usage of internal stream state with public api
cda459e 
Refs: #445

PR-URL: #34884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag left review comments

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lundibundi @nodejs-github-bot @ronag @mcollina @jasnell @addaleax @BridgeAR