Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: re-implement async env cleanup hooks #34819

Closed
wants to merge 6 commits into from
Closed

n-api: re-implement async env cleanup hooks #34819

wants to merge 6 commits into from

Commits on Aug 19, 2020

  1. n-api: re-implement async env cleanup hooks 

    * Avoid passing core `void*` and function pointers into add-on.
* Document `napi_async_cleanup_hook_handle` type.
* Render receipt of the handle mandatory. Removal of the handle remains
  mandatory.

Fixes: nodejs#34715
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
    Gabriel Schulhof committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    28c8a96 View commit details
    Browse the repository at this point in the history

  2. move handle differently

    Gabriel Schulhof committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    5986bab View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Anna Henningsen <github@addaleax.net>
    @gabrielschulhof @addaleax
    2 people authored and Gabriel Schulhof committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    fc6e0b7 View commit details
    Browse the repository at this point in the history

  4. add link to new callback type

    Gabriel Schulhof committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    2d7c4f2 View commit details
    Browse the repository at this point in the history

  5. add changes: sections

    Gabriel Schulhof committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6037705 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. storing the handle at creation is optional again

    Gabriel Schulhof committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    5b694e4 View commit details
    Browse the repository at this point in the history