-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update http_parser to 2.4.0 #345
Conversation
+1 !!! Thanks for quick release. |
+1 just for the how safe is this to land straight into 1.0.0 @indutny? I don't have a feel for how major (and potentially dangerous) these changes are. |
@rvagg I feel safe about it, every commit was reviewed by either me or @bnoordhuis |
ok LGTM then |
PR-URL: #345 Reviewed-By: Rod Vagg <rod@vagg.org>
Landed in d790f61, thank you. |
I just benchmarked using
machine spec: |
Sorry, this is going to be postponed until next release. It breaks build on windows and some tests became flacky (according to users). |
hm, no problem. i am looking forward to next release. |
Test fail with http_parser 2.4.0 on OS X:
|
@jbergstroem is it always failing? Appears to be working on my side. |
@indutny Just tried once (as well as after pulling the revert). Let me check. Edit: Nope, can't reliably reproduce. |
@jbergstroem I think this is just a test problem. I built http-parser with ASAN, and sanitizers for various overflows, and got no errors and no test failures. |
@indutny I haven't seen it since; don't take it into consideration until I can give reliable info. |
n/t
cc @bnoordhuis @rvagg