Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add banner to lint-md.js by rollup.config.js #34233

Merged
merged 1 commit into from
Sep 4, 2020
Merged

tools: add banner to lint-md.js by rollup.config.js #34233

merged 1 commit into from
Sep 4, 2020

Conversation

KuthorX
Copy link
Contributor

@KuthorX KuthorX commented Jul 7, 2020

To avoid someone like me make a mistake in #34218 , rollup.config.js is added a plugin to append a banner on the top of lint-md.js

Checklist

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 7, 2020
@KuthorX KuthorX mentioned this pull request Jul 7, 2020
Closed
2 tasks
@KuthorX
Copy link
Contributor Author

KuthorX commented Jul 7, 2020 •
edited
Loading

This branch need update...I accidentally add other commit...

  • update branch

@Trott
Copy link
Member

Trott commented Jul 7, 2020

If you run make lint-md-rollup, it should generate the file with the banner. You can test that it still works as expected with make lint-md. If everything comes up OK, then maybe commit that generated version in a second commit on this branch?

@KuthorX
Copy link
Contributor Author

KuthorX commented Jul 7, 2020

thanks @Trott , the generated lint-md.js is commited

@KuthorX
Copy link
Contributor Author

KuthorX commented Sep 4, 2020

This pr has been approved but hasn't been merged, could someone merge it or comment to make me improve it?

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2020
@Trott
Copy link
Member

Trott commented Sep 4, 2020 •
edited
Loading

This pr has been approved but hasn't been merged, could someone merge it or comment to make me improve it?

Will run a CI to make sure there aren't any weird surprises. Assuming that goes well, I'll land it. Thanks for your patience!

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33053/

@KuthorX @Trott
tools: add banner to lint-md.js by rollup.config.js
27cf6f7 
PR-URL: nodejs#34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 4, 2020

Landed in 27cf6f7.

Thanks for your patience and thanks for the contribution! 🎉

@Trott Trott merged commit 27cf6f7 into nodejs:master Sep 4, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@KuthorX @richardlau
tools: add banner to lint-md.js by rollup.config.js
b7ea8ff 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
@KuthorX @richardlau
tools: add banner to lint-md.js by rollup.config.js
3d41ff2 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@KuthorX @addaleax
tools: add banner to lint-md.js by rollup.config.js
3e91519 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@KuthorX @addaleax
tools: add banner to lint-md.js by rollup.config.js
1dce35d 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@KuthorX @joesepi
tools: add banner to lint-md.js by rollup.config.js
2e5a797 
PR-URL: nodejs#34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KuthorX @Trott @nodejs-github-bot