Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move sam-github to TSC Emeriti #34095

Closed
wants to merge 1 commit into from
Closed

Conversation

sam-github
Copy link
Contributor

I don't have enough time to remain active in the TSC, so I will step down.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@sam-github sam-github requested a review from mhdawson June 28, 2020 04:30
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2020
I don't have enough time to remain active in the TSC, so I will step down.
@Trott
Copy link
Member

Trott commented Jun 28, 2020

This moves you not just to TSC Emeritus but also to Collaborator Emeritus. Is that intentional? Or did you just intend TSC Emeritus?

Sorry to see you go and hope to see you back some time when you have more cycles for Node.js. Thanks for all the work on security and everything else. And thanks for being a thoughtful collaborator.

sam-github added a commit that referenced this pull request Jul 2, 2020
I don't have enough time to remain active in the TSC, so I will step
down.

PR-URL: #34095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sam-github
Copy link
Contributor Author

Landed in 1aa847f

Thanks you all. And yes, I did want to get removed from collaborators, mostly so at-nodejs/collaborators doesn't ping me :-). If I ever want to PR anything, I still can.

@sam-github
Copy link
Contributor Author

I removed myself from the nodejs and nodejs-private orgs, which should hopefully clean up all my team memberships immediately, so no one has to do that manually.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Jul 2, 2020

Since this only changes the README.m green linter github action is enough, landing. Sam thanks for all of the hard work over the years

@Trott
Copy link
Member

Trott commented Jul 2, 2020

Since this only changes the README.m green linter github action is enough, landing. Sam thanks for all of the hard work over the years

It's already landed. Going through the offboarding checklist right now.

@Trott
Copy link
Member

Trott commented Jul 2, 2020

Sam needs to be removed from the HackerOne Node.js team. Who can do that? /ping @mcollina

@mhdawson
Copy link
Member

mhdawson commented Jul 2, 2020

ah, just figured that out was confused since it was still open.

@mhdawson
Copy link
Member

mhdawson commented Jul 2, 2020

@Trott I think anybody on the TSC can remove him from hacker one

@Trott
Copy link
Member

Trott commented Jul 2, 2020

@Trott I think anybody on the TSC can remove him from hacker one

I cannot view the page to remove people from HackerOne.

@Trott
Copy link
Member

Trott commented Jul 2, 2020

Still needs to be removed from HackerOne (unless someone already took care of it). I can't attend today's TSC meeting but maybe the HackerOne thing can be sorted out there.

Everything else in the offboarding checklist for TSC has been taken care of. I'll close this, and deal with the Collaborators checklist too.

@Trott Trott closed this Jul 2, 2020
@Trott Trott deleted the sam-github-tsc branch July 14, 2020 13:33
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
I don't have enough time to remain active in the TSC, so I will step
down.

PR-URL: #34095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
I don't have enough time to remain active in the TSC, so I will step
down.

PR-URL: #34095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
I don't have enough time to remain active in the TSC, so I will step
down.

PR-URL: #34095
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants