Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: make minor improvements to paragraph in child_process.md #34063

Merged
merged 0 commits into from
Jun 29, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 26, 2020

Use shorter and more direct phrasing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jun 26, 2020
signal that terminated the process. Any exit code other than `0` is considered
to be an error.
the exit code of the process. Any exit code other than `0` indicates an
error. `error.signal` will be the signal that terminated the process.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the “is considered to be an error” phrasing, because it hints at the fact that exit code 0 = success is just a convention and we can’t know whether there actually has been an error.

Copy link
Member Author

@Trott Trott Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?

By convention, any exit code other than `0` indicates an error.

My thinking is that this states plainly that it's a convention, whereas "is considered" only hints at that.

@Trott
Copy link
Member Author

Trott commented Jun 28, 2020

@nodejs/documentation

@Trott
Copy link
Member Author

Trott commented Jun 29, 2020

Landed in 90d5f35

@Trott Trott closed this Jun 29, 2020
@Trott Trott merged commit 90d5f35 into nodejs:master Jun 29, 2020
@Trott Trott deleted the cp-tidy branch June 29, 2020 04:48
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
Use shorter and more direct phrasing.

PR-URL: #34063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
Use shorter and more direct phrasing.

PR-URL: #34063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Use shorter and more direct phrasing.

PR-URL: #34063
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants