Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Powershell to use tls1.2 #33609

Closed
wants to merge 1 commit into from
Closed

Conversation

jschpp
Copy link
Contributor

@jschpp jschpp commented May 28, 2020

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140

Checklist

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: nodejs#33140
@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels May 28, 2020
@BridgeAR
Copy link
Member

@nodejs/platform-windows PTAL

@jschpp
Copy link
Contributor Author

jschpp commented May 28, 2020

I'm stumped as of why the tarball build on macOS failed... I didn't change any code which should impact this test

@bnoordhuis
Copy link
Member

@jschpp Don't worry, that buildbot is a bit problematic. You can ignore the failure.

@jschpp jschpp changed the title Forces Powershell to use tls1.2 Force Powershell to use tls1.2 May 29, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
Copy link
Contributor

@bzoz bzoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the install issue on Win8.1

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bzoz pushed a commit that referenced this pull request Jul 8, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140

PR-URL: #33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@bzoz
Copy link
Contributor

bzoz commented Jul 8, 2020

Landed in b99253c, I took the liberty to solve the merge conflict - it was vs2017 being updated to vs2019.

@bzoz bzoz closed this Jul 8, 2020
@jschpp jschpp deleted the fix-331440 branch July 8, 2020 13:23
@MylesBorins
Copy link
Contributor

This does not land cleanly on v14.x. Should we backport?

@bzoz
Copy link
Contributor

bzoz commented Jul 14, 2020

Yes, this should also go to v12.x

@svdHero
Copy link

svdHero commented Jul 21, 2020

Yes, please add the backport to v14.x.

bzoz added a commit to JaneaSystems/node that referenced this pull request Jul 21, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: nodejs#33140
PR-URL: nodejs#33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140
Backport-PR-URL: #34461
PR-URL: #33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
bzoz added a commit to JaneaSystems/node that referenced this pull request Sep 23, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: nodejs#33140
PR-URL: nodejs#33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Sep 23, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: #33140
PR-URL: #33609
Backport-PR-URL: #34462
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows installation fails with "The request was aborted: Could not create SSL/TLS secure channel."
10 participants