Debug mode tests #3293
Closed
Debug mode tests #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1304,7 +1304,7 @@ def ProcessOptions(options): | |||
| global VERBOSE | |||
| VERBOSE = options.verbose | |||
| options.arch = options.arch.split(',') | |||
| options.mode = options.mode.split(',') | |||
| options.mode = options.mode.lower().split(',') # 'Release' => 'release'. | |||
There was a problem hiding this comment.
I'm not sure this comment really adds value here
There was a problem hiding this comment.
I figured that it wasn't entirely obvious from context what options.mode is and why it needs to be lower-cased. I can remove it if you feel strongly about it.
|
There's a few others in there that could have |
|
@bnoordhuis good stuff. Changes generally LGTM, though the add-ons tests still need to be fixed. Prototype job run here: https://ci.nodejs.org/job/orangemocha-test-commit-linux/2/ (still pending) |
|
@bnoordhuis ... ping |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4
to
c7066fb
Compare
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999
to
83c7a88
Compare
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3280.
R=@orangemocha
I'll spruce up the commit logs but this is the basic idea of what I mentioned here.