Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use tabs for indentation in Makefile #32614

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 2, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 2, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 2, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member

addaleax commented Apr 6, 2020

Landed in 78e6d24

addaleax pushed a commit that referenced this pull request Apr 6, 2020
PR-URL: #32614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax closed this Apr 6, 2020
@lpinca lpinca deleted the use/tab-indentation branch April 6, 2020 05:25
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
PR-URL: #32614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member

Trott commented Apr 7, 2020

These changes appear to have broken this functionality. It now lints every .md file when one .md file is changed. Changing the tabs back to spaces fixes it so it only lints the changed file.

@Trott
Copy link
Member

Trott commented Apr 7, 2020

Looks like other recipes in the Makefile get around this by not indenting lines after ifeq and friends. I'll open a PR to make that change here.

@Trott Trott mentioned this pull request Apr 7, 2020
3 tasks
@Trott
Copy link
Member

Trott commented Apr 7, 2020

#32712

Trott added a commit to Trott/io.js that referenced this pull request Apr 10, 2020
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.

Refs: nodejs#32614 (comment)

PR-URL: nodejs#32712
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
PR-URL: #32614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.

Refs: #32614 (comment)

PR-URL: #32712
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.

Refs: #32614 (comment)

PR-URL: #32712
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #32614
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Indentation with a tab breaks the functionality, resulting in linting
all .md files when any one is changed. For consistency with the rest of
the Makefile and to restore functionality, remove indentation.

Refs: #32614 (comment)

PR-URL: #32712
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants