Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add WASI test for file resizing #31617

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 2, 2020

This commit adds a WASI test to cover the following functions:

  • __wasi_fd_filestat_set_size()
  • __wasi_fd_tell()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2020
test/wasi/c/ftruncate.c Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 11, 2020

Looks like the ARM 12 bots were not happy with the new test. Will need to debug.

@cjihrig
Copy link
Contributor Author

cjihrig commented May 23, 2020

What is the current situation with the ARM fanned CI job. I notice that it's inactive, and has been for a while now. That was the only place I was able to see this test fail. Is the ARM fanned job going to be coming back?

@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:19
@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 2, 2020

@nodejs/build can you shed some light on the future plans for the ARM fanned CI job (see my previous comment)?

@rvagg
Copy link
Member

rvagg commented Jun 3, 2020

Yeah, they're offline for now, we just didn't have enough disk to consistently keep them online. The size of the repo & builds just pushes the limits on the disks shared across the cluster. I've come into possession of a new 500Gb SSD that I don't have use for elsewhere that I've started copying data to, it just needs me to allocate the time to reconfigure the NFS mounts to get it all back up again. Will try and not let this slip too much longer.

@nodejs-github-bot
Copy link
Collaborator

@rvagg
Copy link
Member

rvagg commented Jun 8, 2020

arm-fanned back online now and you're getting a clean failure on this: https://ci.nodejs.org/job/node-test-binary-arm-12+/5681/RUN_SUBSET=1,label=pi3-docker/console

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 13, 2020

This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: nodejs#31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@cjihrig cjihrig merged commit 2abbadd into nodejs:master Jul 13, 2020
@cjihrig cjihrig deleted the wasi-test branch July 13, 2020 15:54
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: #31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: #31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig added a commit that referenced this pull request Jul 23, 2020
This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: #31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: #31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
This commit adds a WASI test to cover the following functions:

- __wasi_fd_filestat_set_size()
- __wasi_fd_tell()

PR-URL: #31617
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants