Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add promises metadata to postmortem test #31357

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

type_JSPromise__JS_PROMISE_TYPE and
type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to
identify Promises in memory and core dumps:
nodejs/llnode#272. Add these to our postmortem
test so we're aware of any changes to this metadata.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

type_JSPromise__JS_PROMISE_TYPE and
type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to
identify Promises in memory and core dumps:
nodejs/llnode#272. Add these to our postmortem
test so we're aware of any changes to this metadata.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 14, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 14, 2020

@Trott
Copy link
Member

Trott commented Jan 16, 2020

Might V8 benchmark failure be related to Python 3?:

15:19:14 Warning: gclient doesn't yet support Python 3 and may not work correctly.
15:19:14 Error: Command 'download_from_google_storage --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s v8/buildtools/linux64/clang-format.sha1' returned non-zero exit status 1 in .

@richardlau
Copy link
Member

Might V8 benchmark failure be related to Python 3?:

15:19:14 Warning: gclient doesn't yet support Python 3 and may not work correctly.
15:19:14 Error: Command 'download_from_google_storage --no_resume --platform=linux* --no_auth --bucket chromium-clang-format -s v8/buildtools/linux64/clang-format.sha1' returned non-zero exit status 1 in .

Yes, #30152 (and #24512).

@mmarchini
Copy link
Contributor Author

mmarchini commented Jan 16, 2020

Runninng a freestyle for v8-updates instead: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11601/console I thought the linux-perf test flakiness was fixed :/ here's another attempt: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11603/

@mmarchini
Copy link
Contributor Author

Landed in cf5624c

mmarchini added a commit that referenced this pull request Jan 16, 2020
type_JSPromise__JS_PROMISE_TYPE and
type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to
identify Promises in memory and core dumps:
nodejs/llnode#272. Add these to our postmortem
test so we're aware of any changes to this metadata.

PR-URL: #31357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mmarchini mmarchini closed this Jan 16, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
type_JSPromise__JS_PROMISE_TYPE and
type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to
identify Promises in memory and core dumps:
nodejs/llnode#272. Add these to our postmortem
test so we're aware of any changes to this metadata.

PR-URL: #31357
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
@codebytere
Copy link
Member

@mmarchini should this go back to v12.x? it doesn't land cleanly and would need a manual backport. I'll set the label but feel free to swap it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants