Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve WASI start() coverage #30972

Closed
wants to merge 2 commits into from
Closed

test: improve WASI start() coverage #30972

wants to merge 2 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 15, 2019

This PR should get the WASI start() JS test coverage to 100%.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@cjihrig
test: improve WASI start() coverage
047ed0a 
This commit adds additional test cases to
test-wasi-start-validation.js, which gets the JS test coverage
of start() to 100%.
@cjihrig
test: simplify test-wasi-start-validation.js
f5540d5 
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 15, 2019
@gengjiawen gengjiawen added wasi Issues and PRs related to the WebAssembly System Interface. wasm Issues and PRs related to WebAssembly. labels Dec 15, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 15, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27704/ 💛

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@Trott
Copy link
Member

Trott commented Dec 17, 2019

Landed in 14af00e...0a2355f

@Trott Trott closed this Dec 17, 2019
Trott pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @Trott
test: improve WASI start() coverage
bd91d6d 
This commit adds additional test cases to
test-wasi-start-validation.js, which gets the JS test coverage
of start() to 100%.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @Trott
test: simplify test-wasi-start-validation.js
0a2355f 
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig deleted the wasi-start-cov branch December 17, 2019 14:23
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @MylesBorins
test: improve WASI start() coverage
c2d9552 
This commit adds additional test cases to
test-wasi-start-validation.js, which gets the JS test coverage
of start() to 100%.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@cjihrig @MylesBorins
test: simplify test-wasi-start-validation.js
5e268b8 
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@cjihrig @targos
test: improve WASI start() coverage
299d518 
This commit adds additional test cases to
test-wasi-start-validation.js, which gets the JS test coverage
of start() to 100%.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2020
@cjihrig @targos
test: simplify test-wasi-start-validation.js
d676c6c 
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
test: improve WASI start() coverage
be3fd2e 
This commit adds additional test cases to
test-wasi-start-validation.js, which gets the JS test coverage
of start() to 100%.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
test: simplify test-wasi-start-validation.js
ceca549 
This commit removes an extra block scope, and avoid reading
the simple.wasm file for every test case.

PR-URL: #30972
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. wasi Issues and PRs related to the WebAssembly System Interface. wasm Issues and PRs related to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @Trott @jasnell @gengjiawen @BridgeAR