Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-os-checked-function work without test harness #30914

Closed
wants to merge 2 commits into from
Closed

test: make test-os-checked-function work without test harness #30914

wants to merge 2 commits into from

Commits on Dec 12, 2019

  1. test: delay loading 'os' in test/common module 

    There is a test that doesn't load the common module initially because it
needs to monkey-patch the 'os' module. I think it would be a good idea
to minimize the side-effects of loading common anyway, so let's defer
loading 'os' unless/until it's actually needed.
    @Trott
    Trott committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    df52e03 View commit details
    Browse the repository at this point in the history

  2. test: make test-os-checked-function work without test harness 

    Most tests in `test/parallel` work when invoked with `node` rather than
`tools/test.py` but not test-os-checked-function because it doesn't load
the `common` module initially, which means it won't get re-spawned with
the necessary flags (in the Flags: comment, in this case
--expose_internals). Now that common delays loading 'os' until it needs
to load it, this test can load the common module and it will work from
the command line without the test harness. Additionally, we now can
remove a comment disabling a lint rule.
    @Trott
    Trott committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    352853e View commit details
    Browse the repository at this point in the history