Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove dead code #30041

Closed
wants to merge 2 commits into from
Closed

stream: remove dead code #30041

wants to merge 2 commits into from

Commits on Oct 20, 2019

  1. stream: remove dead code 

    `String.prototype.split()` returns an array of strings so the branch is
never taken.

Fixes: nodejs#30040
    @lpinca
    lpinca committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    71e86ab View commit details
    Browse the repository at this point in the history

  2. stream: simplify uint8ArrayToBuffer helper 

    The fallback code is no longer used when exporting to readable-stream.

Refs: nodejs#29514
    @lpinca
    lpinca committed Oct 20, 2019
    Configuration menu
    Copy the full SHA
    3d144c1 View commit details
    Browse the repository at this point in the history