Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: notes about forwarding stream options #29857

Closed
wants to merge 3 commits into from
Closed

doc: notes about forwarding stream options #29857

wants to merge 3 commits into from

Commits on Oct 6, 2019

  1. doc: notes about forwarding stream options 

    It is a common and unfortunate pattern to simply just forward
any and all options into the base constructor without taking
into account whether these options might conflict with basic
stream assumptions.
    @ronag
    ronag committed Oct 6, 2019
    Configuration menu
    Copy the full SHA
    58c813f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2019

  1. fixup: autoDestroy

    @ronag
    ronag committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    e919ab6 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Apply suggestions from code review 

    Co-Authored-By: Rich Trott <rtrott@gmail.com>
    @ronag @Trott
    ronag and Trott committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    50ee054 View commit details
    Browse the repository at this point in the history