Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add devnexen to collaborators #29370

Closed
wants to merge 1 commit into from
Closed

doc: add devnexen to collaborators #29370

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 29, 2019
@devnexen devnexen added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 29, 2019
@devnexen
Copy link
Contributor Author

Collaborators please 👍 to fast-track :)

Trott
Trott requested changes Aug 29, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Looks like you put your name in the "Collaborator Emeriti" list. "Emeriti" is for past Collaborators. Can you move it to the active Collaborators list instead?

@devnexen
Copy link
Contributor Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3868/

devnexen added a commit that referenced this pull request Aug 29, 2019
@devnexen
doc: add devnexen to collaborators
ecd9842 
PR-URL: #29370
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@devnexen
Copy link
Contributor Author

Landed in ecd9842

@devnexen devnexen closed this Aug 29, 2019
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 29, 2019
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@devnexen @BridgeAR
doc: add devnexen to collaborators
28b1a49 
PR-URL: #29370
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 4, 2019
@devnexen @BridgeAR
doc: add devnexen to collaborators
a94afed 
PR-URL: #29370
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @Trott @cjihrig @richardlau @nodejs-github-bot