util: do not throw when inspecting detached ArrayBuffer #29318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
cjihrig
approved these changes
Aug 25, 2019
addaleax
added
the
author ready
jasnell
approved these changes
Aug 26, 2019
lpinca
approved these changes
Aug 26, 2019
trivikr
approved these changes
Aug 26, 2019
Fishrock123
approved these changes
Aug 27, 2019
devsnek
approved these changes
Aug 27, 2019
| new MessageChannel().port1.postMessage(ab, [ ab ]); | ||
| assert.strictEqual(ab.byteLength, 0); | ||
| assert.strictEqual(util.inspect(ab), | ||
| 'ArrayBuffer { (detached), byteLength: 0 }'); |
There was a problem hiding this comment.
we'll probably want to remove byteLength at some point in the future, but this looks good.
danbev
added
author ready
danbev
pushed a commit
that referenced
this pull request
Aug 29, 2019
PR-URL: #29318 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gus Caplan <me@gus.host>
|
Landed in a194eac. |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29318 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
PR-URL: #29318 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gus Caplan <me@gus.host>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 23, 2019
Node workers don't work in Electron. Disabled due to test introduced in nodejs/node#29318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes