Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "src: remove trace_sync_io_ from env" #28926

Closed
wants to merge 1 commit into from

Commits on Aug 2, 2019

  1. Revert "src: remove trace_sync_io_ from env"

    This reverts commit 7fa5f54.
    
    The reverted commit breaks the logic behind --trace-sync-io, it should
    be enabled only at a certain point in time, while that commit enables
    it from the very start, causing warnings be printed for all sync io
    instead of sync io after the first tick of the event loop as documented.
    
    Fixes: nodejs#28913
    Refs: nodejs#22726
    Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io
    PR-URL: nodejs#28926
    ChALkeR committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    31973cc View commit details
    Browse the repository at this point in the history