Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, util: refactor isObject in test-util #28878

Closed
wants to merge 1 commit into from
Closed

test, util: refactor isObject in test-util #28878

wants to merge 1 commit into from

Conversation

RamirezAlex
Copy link
Contributor

Refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

  • make -j4 test (UNIX)
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@RamirezAlex
test, util: refactor isObject in test-util
abb65e4 
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 27, 2019
@hiroppy hiroppy added the util Issues and PRs related to the built-in util module. label Jul 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24730/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 28, 2019
@Trott
Copy link
Member

Trott commented Jul 29, 2019

Landed in 2713f78

@Trott Trott closed this Jul 29, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 29, 2019
@RamirezAlex @Trott
test, util: refactor isObject in test-util
2713f78 
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: nodejs#28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
@RamirezAlex @targos
test, util: refactor isObject in test-util
84efadf 
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: #28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RamirezAlex @nodejs-github-bot @Trott @jasnell @targos @cjihrig @hiroppy @ZYSzys