process: refactor unhandledRejection logic #28540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
process
joyeecheung
approved these changes
Jul 5, 2019
shisama
approved these changes
Jul 5, 2019
BridgeAR
approved these changes
Jul 5, 2019
Trott
approved these changes
Jul 5, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/24316/ EDIT(cjihrig): CI was green. |
cjihrig
added
the
author ready
addaleax
approved these changes
Jul 6, 2019
This commit prevents a deprecation warning from being emitted if the unhandledRejection event was actually handled. PR-URL: nodejs#28540 Fixes: nodejs#28539 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit prevents a deprecation warning from being emitted if the unhandledRejection event was actually handled. PR-URL: #28540 Fixes: #28539 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jul 23, 2019
ehmicky
added a commit
to ehmicky/log-process-errors
that referenced
this pull request
Jul 31, 2019
It's due to a bug introduced in Node 12.6.0 but fixed in 12.7.0 nodejs/node#28540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents a deprecation warning from being emitted
if the
'unhandledRejection'event was actually handled.Fixes: #28539
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes