Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generate des rsa_cert.pfx #28471

Closed
wants to merge 1 commit into from
Closed

Commits on Jun 28, 2019

  1. test: generate des rsa_cert.pfx

    My node distribution uses a shared openssl library with some ciphers
    disabled, including RC2.
    
    These tests (which use `rsa_cert.pfx`) fail with `unknown cipher`:
     - parallel/test-crypto-binary-default
     - parallel/test-https-pfx
     - parallel/test-crypto
    
    The other fixture .pfx's use the `-descert` option, I don't know if
    rsa_cert.pfx was generated without `-descert` intentionally or not but
    none of the tests reference RC2, and the tests pass with a des cert.
    
    I'm not an ssl/crypto expert, so I would appreciate any insight.
    
    Old key:
    ```
    openssl pkcs12 -info -in test/fixtures/keys/rsa_cert.pfx -noout -passin
    pass:sample
    MAC Iteration 2048
    MAC verified OK
    PKCS7 Encrypted data: pbeWithSHA1And40BitRC2-CBC, Iteration 2048
    Certificate bag
    PKCS7 Data
    Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048
    ```
    
    New
    ```
    openssl pkcs12 -info -in test/fixtures/keys/rsa_cert.pfx -noout -passin
    pass:sample
    MAC Iteration 2048
    MAC verified OK
    PKCS7 Encrypted data: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048
    Certificate bag
    PKCS7 Data
    Shrouded Keybag: pbeWithSHA1And3-KeyTripleDES-CBC, Iteration 2048
    ```
    Caleb ツ Everett committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    5461c1e View commit details
    Browse the repository at this point in the history