Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: pass path in URL constructor #28161

Closed
wants to merge 1 commit into from
Closed

doc: pass path in URL constructor #28161

wants to merge 1 commit into from

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Jun 10, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

simplifies doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Jun 14, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3679/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Jun 14, 2019

Landed in b5e8181 🎉

@ZYSzys ZYSzys closed this Jun 14, 2019
ZYSzys pushed a commit that referenced this pull request Jun 14, 2019
@dnalborczyk @ZYSzys
doc: pass path in URL constructor
b5e8181 
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@dnalborczyk @BridgeAR
doc: pass path in URL constructor
07ab591 
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@dnalborczyk @targos
doc: pass path in URL constructor
694faf1 
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dnalborczyk @ZYSzys @jasnell @Trott @lpinca @TimothyGu @BridgeAR @nodejs-github-bot