Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finish code coverage for lib/internal/worker.js #27995

Merged
merged 2 commits into from
Jun 2, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented May 31, 2019

Two commits to complete code coverage for lib/internal/worker.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@Trott Trott added test Issues and PRs related to the tests. worker Issues and PRs related to Worker support. labels May 31, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott changed the title test: finish code coverage for lib/internal/worker.js.html test: finish code coverage for lib/internal/worker.js May 31, 2019
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is happy.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 1, 2019
Trott added 2 commits June 2, 2019 17:50
Check that the main thread handles unserializable errors in a worker
thread as expected.

PR-URL: nodejs#27995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Check that main thread handles an unknown message type from a worker
thread as expected.

PR-URL: nodejs#27995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 2, 2019

Landed in df339bc...e8f3119

@Trott Trott merged commit e8f3119 into nodejs:master Jun 2, 2019
targos pushed a commit that referenced this pull request Jun 3, 2019
Check that the main thread handles unserializable errors in a worker
thread as expected.

PR-URL: #27995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 3, 2019
Check that main thread handles an unknown message type from a worker
thread as expected.

PR-URL: #27995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
@Trott Trott deleted the unserializable-error branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants