Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing --experimental-wasm-modules docs #27948

Merged
merged 1 commit into from
May 31, 2019
Merged

doc: add missing --experimental-wasm-modules docs #27948

merged 1 commit into from
May 31, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 29, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

richardlau
richardlau approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a Refs: https://github.com/nodejs/node/pull/27659 to the commit message to link back to the implementation?

@Trott
Copy link
Member

Trott commented May 30, 2019 •
edited by cjihrig
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3636/

EDIT(cjihrig): CI was green.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2019
@cjihrig
doc: add missing --experimental-wasm-modules docs
d26473b 
PR-URL: nodejs#27948
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit d26473b into nodejs:master May 31, 2019
@cjihrig cjihrig deleted the doc branch May 31, 2019 13:37
targos pushed a commit that referenced this pull request May 31, 2019
@cjihrig @targos
doc: add missing --experimental-wasm-modules docs
77ff597 
PR-URL: #27948
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@guybedford guybedford guybedford approved these changes

@Trott Trott Trott approved these changes

@Leko Leko Leko approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @Trott @jasnell @guybedford @Leko @richardlau @BridgeAR @trivikr