Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add util inspect null getter test #27884

Closed
wants to merge 2 commits into from

Conversation

mihan007
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@ryzokuken ryzokuken added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. /cc @BridgeAR

@addaleax
Copy link
Member

@mihan007 Could you take a look at the linter failures?

/home/travis/build/nodejs/node/test/parallel/test-util-inspect.js
  342:50  error  Missing semicolon               semi
  344:28  error  A space is required after '{'   object-curly-spacing
  344:42  error  A space is required before '}'  object-curly-spacing

@mihan007
Copy link
Contributor Author

@addaleax fixed

@nodejs-github-bot
Copy link
Collaborator

@ChALkeR ChALkeR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@ryzokuken
Copy link
Contributor

ryzokuken commented May 28, 2019

Failure:

18:32:50 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x218): undefined reference to `v8::internal::StatisticsExtension::kSource'
18:32:50 /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/obj.target/v8_base/deps/v8/src/bootstrapper.o:(.toc1+0x228): undefined reference to `vtable for v8::internal::StatisticsExtension'
18:32:51 collect2: error: ld returned 1 exit status
18:32:51 make[2]: *** [/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/out/Release/mksnapshot] Error 1

Completely unrelated to the PR, I guess?

@nodejs-github-bot
Copy link
Collaborator

@ryzokuken
Copy link
Contributor

The tests pass but there's a... performance regression?

@Trott
Copy link
Member

Trott commented May 29, 2019

The tests pass but there's a... performance regression?

@ryzokuken Can you elaborate on that? I'm not sure what you're referring to but I am certainly curious.

@Trott
Copy link
Member

Trott commented May 30, 2019

@Trott according to https://ci.nodejs.org/job/node-test-commit/28968/, all tests passed, but https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_debug_x64/13006/testReport/junit/(root)/test/sequential_test_performance/ reports a performance regression.

Ah! test-performance isn't a performance regression test. It's a test of the perf_hooks module.

@ryzokuken
Copy link
Contributor

@Trott I see! Sorry for misunderstanding.

@Trott
Copy link
Member

Trott commented May 30, 2019

@Trott I see! Sorry for misunderstanding.

No worries! The only reason I know that is because I made the same exact mistake in the past! The test might benefit from being renamed test-perf-hooks

@ryzokuken
Copy link
Contributor

@Trott I could make a PR 🤷‍♂

ryzokuken added a commit to ryzokuken/node that referenced this pull request May 30, 2019
Rename test-performance to test-perf-hooks to better match its function

Refs: nodejs#27884 (comment)
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
PR-URL: nodejs#27884
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in 1dbf276

@Trott Trott closed this May 30, 2019
@Trott
Copy link
Member

Trott commented May 30, 2019

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request May 31, 2019
PR-URL: #27884
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
ryzokuken added a commit that referenced this pull request Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function

Refs: #27884 (comment)

PR-URL: #27969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jun 1, 2019
Rename test-performance to test-perf-hooks to better match its function

Refs: #27884 (comment)

PR-URL: #27969
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants