Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: group chunks into TLS segments #27861

Closed
wants to merge 1 commit into from

Commits on May 28, 2019

  1. tls: group chunks into TLS segments

    TLSWrap::DoWrite() now concatenates data chunks and makes a single
    call to SSL_write(). Grouping data into a single segment:
    
    - reduces network overhead: by factors of even 2 or 3 in usages
      like `http2` or `form-data`
    
    - improves security: segment lengths can reveal lots of info, i.e.
      with `form-data`, how many fields are sent and the approximate length
      of every individual field and its headers
    
    - reduces encryption overhead: a quick benchmark showed a ~30% CPU time
      decrease for an extreme case, see
      nodejs#27573 (comment)
    
    Fixes: nodejs#27573
    mildsunrise committed May 28, 2019
    Configuration menu
    Copy the full SHA
    4ef156b View commit details
    Browse the repository at this point in the history