Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove non-existent entry-type flag #27678

Closed
wants to merge 2 commits into from
Closed

doc: remove non-existent entry-type flag #27678

wants to merge 2 commits into from

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented May 13, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

possible leftover from: #27184

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 13, 2019
Trott
Trott previously approved these changes May 13, 2019
View reviewed changes
@Trott Trott self-requested a review May 13, 2019 22:03
@Trott Trott dismissed their stale review May 13, 2019 22:03

have a question....

Trott
Trott reviewed May 13, 2019
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
Trott
Trott reviewed May 13, 2019
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

LGTM with the comments addressed. Refs: #27184

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23152/

@guybedford guybedford mentioned this pull request May 16, 2019
Closed
4 tasks
@guybedford
Copy link
Contributor

Landed in 545b59e.

@guybedford guybedford closed this May 16, 2019
guybedford pushed a commit that referenced this pull request May 16, 2019
@dnalborczyk @guybedford
doc: remove non-existent entry-type flag
545b59e 
PR-URL: #27678
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 17, 2019
@dnalborczyk @targos
doc: remove non-existent entry-type flag
d570995 
PR-URL: #27678
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
@dnalborczyk dnalborczyk deleted the patch-5 branch July 31, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dnalborczyk @BridgeAR @nodejs-github-bot @guybedford @Trott @trivikr