Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix createRequireFromPath() slash logic #27634

Merged
merged 1 commit into from
May 13, 2019
Merged

module: fix createRequireFromPath() slash logic #27634

merged 1 commit into from
May 13, 2019

Commits on May 13, 2019

  1. module: fix createRequireFromPath() slash logic 

    The trailing slash detection logic in createRequireFromPath()
seemed slightly incorrect. This commit reworks the logic.

PR-URL: nodejs#27634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
    @cjihrig
    cjihrig committed May 13, 2019
    Configuration menu
    Copy the full SHA
    ef51cc8 View commit details
    Browse the repository at this point in the history