Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: vm module error thrown when breakOnSigint is not a boolean evaluate() #27503

Closed
wants to merge 2 commits into from
Closed

test: vm module error thrown when breakOnSigint is not a boolean evaluate() #27503

wants to merge 2 commits into from

Conversation

rpgeeganage
Copy link
Contributor

This unit test is to assert the error thrown when none boolean value passed as breakOnSigint attribute to the evaluate() function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2019
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. vm Issues and PRs related to the vm subsystem. labels May 1, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22865/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22909/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22913/

@rpgeeganage
Copy link
Contributor Author

@trivikr , thanks for approving the PR.
I started contributing after watching your video Start your Node.js contribution by writing unit tests quickly with VSCode - Trivikram Kamat. Thanks for the awsome stuff.

@trivikr
Copy link
Member

trivikr commented May 6, 2019

@rpgeeganage Thank you! I'm happy that the video was helpful 😄

@ZYSzys
Copy link
Member

ZYSzys commented May 11, 2019

Landed in 8b78fbd 🎉

@ZYSzys ZYSzys closed this May 11, 2019
ZYSzys pushed a commit that referenced this pull request May 11, 2019
@rpgeeganage @ZYSzys
test: test error when breakOnSigint is not a boolean for evaluate
8b78fbd 
PR-URL: #27503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request May 13, 2019
@rpgeeganage @targos
test: test error when breakOnSigint is not a boolean for evaluate
0c7f18e 
PR-URL: #27503
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpgeeganage @nodejs-github-bot @trivikr @ZYSzys @Trott @addaleax