Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async_hooks: fixup do not reuse HTTPParser #27477

Closed
wants to merge 7 commits into from
Closed

async_hooks: fixup do not reuse HTTPParser #27477

wants to merge 7 commits into from

Commits on Apr 29, 2019

  1. async_hooks: fixup do not reuse HTTPParser

    Fix some issues introduced/not fixed via
    #25094:
    * Init hook is not emitted for a reused HTTPParser
    * HTTPParser was still used as resource in init hook
    * type used in init hook was always HTTPINCOMINGMESSAGE even for client
    requests
    * some tests have not been adapted to new resource names
    
    With this change the async hooks init event is emitted during a call
    to Initialize() as the type and resource object is available at this
    time. As a result Initialize() must be called now which could be seen
    as breaking change even HTTPParser is not part of documented API.
    
    It was needed to put the ClientRequest instance into a wrapper object
    instead passing it directly as async resource otherwise
    test-domain-multi fails. I think this is because adding an EventEmitter
    to a Domain adds a property 'domain' and the presence of this changes
    the context propagation in domains.
    
    Besides that tests still refering to resource HTTPParser have been
    updated/improved.
    
    Fixes: #27467
    Fixes: #26961
    Refs: #25094
    Flarna committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    60479d4 View commit details
    Browse the repository at this point in the history
  2. make initialize() mandatory

    Flarna committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    40842c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4c189d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8bc5f1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d790d2 View commit details
    Browse the repository at this point in the history
  6. fixup: adapt bench-parser

    Flarna committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    565d515 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. Configuration menu
    Copy the full SHA
    4677245 View commit details
    Browse the repository at this point in the history