Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: improve ArrayBuffer performance in v8 #2732

Closed
wants to merge 1 commit into from

Commits on Sep 8, 2015

  1. deps: improve ArrayBuffer performance in v8

    This a backport of the following commits from the v8's upstream:
    
    * 1a8c38c50513f9af07ada479629a653e1cf36ff3
    * 206f12abee3f1e7eda8fc6521d48f3c319460ee1
    * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33
    
    Original commit message:
    
        heap: make array buffer maps disjoint
    
        Remove intersection from the `std::map`s representing current live
        ArrayBuffers. While being simpler to understand, it poses
        significant performance issue for the active ArrayBuffer users (like
        node.js).
    
        Store buffers separately, and process them together during
        mark-sweep phase.
    
        The results of benchmarks are:
    
        $ ./node-slow bench && ./node-fast bench
        4997.4 ns/op
        4685.7 ns/op
    
        NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js
        with vanilla v8.
    indutny committed Sep 8, 2015
    Configuration menu
    Copy the full SHA
    319edd4 View commit details
    Browse the repository at this point in the history