Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fs promises, fixes comment, simplifies test #27242

Merged
merged 1 commit into from
Jun 2, 2019
Merged

test: fs promises, fixes comment, simplifies test #27242

merged 1 commit into from
Jun 2, 2019

Conversation

dnalborczyk
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

fixes some leftover from : #26581

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 15, 2019
BridgeAR
BridgeAR approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a suggestion.

test/parallel/test-fs-promises.js Show resolved Hide resolved
ZYSzys
ZYSzys approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if comments landed.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 2, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23562/

@dnalborczyk @Trott
test: simplify fs promises test
e0c4a9c 
Simplify test, fix comment.

PR-URL: nodejs#27242
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Jun 2, 2019

Landed in e0c4a9c

@Trott Trott merged commit e0c4a9c into nodejs:master Jun 2, 2019
targos pushed a commit that referenced this pull request Jun 3, 2019
@dnalborczyk @targos
test: simplify fs promises test
887dd60 
Simplify test, fix comment.

PR-URL: #27242
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 3, 2019
Merged
@dnalborczyk dnalborczyk deleted the fs-promises branch June 5, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dnalborczyk @nodejs-github-bot @Trott @lpinca @BridgeAR @shisama @ZYSzys