tools: remove hyphen in TAP result #2718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: LGTM after below nit. commit message: |
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen.
thefourtheye
force-pushed
the
fix-tap-format
branch
from
1603006
to
a2448fa
Compare
|
@jbergstroem he he he. Done. Thanks for pointing out :D |
thefourtheye
changed the title
thefourtheye
added a commit
that referenced
this pull request
Sep 12, 2015
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: #2718 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Thanks for the review @jbergstroem :-) Landed in de05175 |
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: #2718 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
thefourtheye
added a commit
that referenced
this pull request
Sep 15, 2015
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: #2718 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is, the TAP result shows an extra hyphen in front of test names.
Sample:
ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/
This patch removes the extra hyphen.
R = @jbergstroem ?