lib: create primordials in every context #27171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Apr 10, 2019
joyeecheung
commented
Apr 10, 2019
| Object, | ||
| Symbol | ||
| } = primordials; | ||
|
|
||
| class ERR_INVALID_THIS extends TypeError { |
There was a problem hiding this comment.
On a side note, we'd probably want to make the Errors part of primordials too, but I am not yet sure how this would work for e.g. error-serdes, or if how it works with our internal errors (because we do need to assign properties to the instances dynamically, they probably can't be frozen).
jasnell
approved these changes
Apr 10, 2019
|
#27146 landed and there's a small conflict. |
This allows us to use primordials in other per-context scripts.
joyeecheung
force-pushed
the
per-context-primordials
branch
from
ffad5aa
to
81ee19d
Compare
joyeecheung
added
the
author ready
|
Landed in dfd7e99...914d6c9 |
joyeecheung
added a commit
that referenced
this pull request
Apr 13, 2019
This allows us to use primordials in other per-context scripts. PR-URL: #27171 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung
added a commit
that referenced
this pull request
Apr 13, 2019
PR-URL: #27171 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: create primordials in every context
This allows us to use primordials in other per-context scripts.
lib: use primordials in domexception.js
To complete #27146
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes