Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enhance fs-watch-recursive test #2599

Closed

Conversation

thefourtheye
Copy link
Contributor

This patch

  • issues a TAP plugin parsable message for non-darwin environments
  • uses const wherever applicable
  • moves the test to parallel

CI Run: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/202/

@thefourtheye thefourtheye added the test Issues and PRs related to the tests. label Aug 28, 2015
@Fishrock123
Copy link
Contributor

cc @nodejs/build again

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Sep 14, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel
@thefourtheye
Copy link
Contributor Author

Rebased and doing CI: https://ci.nodejs.org/job/node-test-pull-request/671/

@thefourtheye
Copy link
Contributor Author

Wow. Almost all green. Any reviewers? cc @nodejs/collaborators ?

@thefourtheye
Copy link
Contributor Author

Bump!

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Nov 10, 2015

LGTM!

thefourtheye added a commit that referenced this pull request Nov 10, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Nov 10, 2015

Landed in a28b938

@jasnell jasnell closed this Nov 10, 2015
@thefourtheye thefourtheye deleted the improve-fs-watch-recursive branch November 10, 2015 16:30
thefourtheye added a commit that referenced this pull request Nov 11, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Nov 11, 2015
thefourtheye added a commit that referenced this pull request Nov 16, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

landed in lts as 75b4613

thefourtheye added a commit that referenced this pull request Dec 4, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Dec 17, 2015
thefourtheye added a commit that referenced this pull request Dec 17, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
thefourtheye added a commit that referenced this pull request Dec 23, 2015
This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: #2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants